Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise tutorial to separate out platforms #397

Merged
merged 3 commits into from
May 4, 2024
Merged

Revise tutorial to separate out platforms #397

merged 3 commits into from
May 4, 2024

Conversation

natke
Copy link
Contributor

@natke natke commented May 3, 2024

No description provided.

parinitarahi
parinitarahi reviewed May 3, 2024
View reviewed changes
Copy link
Contributor

@parinitarahi parinitarahi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The -m argument is the path to the model you downloaded from HuggingFace above. ---> should be The -m argument is path to the model folder downloaded from HuggingFace above.

sophies927
sophies927 reviewed May 3, 2024
View reviewed changes
Copy link
Contributor

@sophies927 sophies927 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some suggestions to fix links in "Choose your platform" section

examples/python/phi-3-tutorial.md Outdated Show resolved Hide resolved
examples/python/phi-3-tutorial.md Outdated Show resolved Hide resolved
examples/python/phi-3-tutorial.md Outdated Show resolved Hide resolved
@natke
Copy link
Contributor Author

natke commented May 3, 2024

The -m argument is the path to the model you downloaded from HuggingFace above. ---> should be The -m argument is path to the model folder downloaded from HuggingFace above.

That's no longer in the current tutorial. Do you want me to add it?

@natke natke merged commit c9d279e into microsoft:main May 4, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sophies927 sophies927 sophies927 left review comments

@parinitarahi parinitarahi parinitarahi left review comments

@baijumeswani baijumeswani baijumeswani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@natke @baijumeswani @parinitarahi @sophies927